Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format DEFAULT VALUES clause for Postgres #720

Conversation

nwalters512
Copy link
Contributor

Closes #718.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@@ -23,6 +23,7 @@ const reservedClauses = expandPhrases([
// - insert:
'INSERT INTO',
'VALUES',
'DEFAULT VALUES',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure exactly which of the "clauses" arrays this belongs in, though it seems to not matter for the tests. If you'd rather this be moved to another array, please let me know.

@nene
Copy link
Collaborator

nene commented Feb 20, 2024

Thanks. There's indeed not much of a difference into which *clauses array to place this as there won't be no items following DEFAULT VALUES that should be nested inside it.

@nene nene merged commit e2bb28b into sql-formatter-org:master Feb 20, 2024
2 checks passed
@nwalters512 nwalters512 deleted the format-postgres-default-values-clause branch May 30, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FORMATTING] DEFAULT VALUES not properly supported in INSERT statement
2 participants