Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for FLOAT for PostgreSQL Binary Arithmetic Operators #655

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Add support for FLOAT for PostgreSQL Binary Arithmetic Operators #655

wants to merge 32 commits into from

Conversation

albertZhangTJ
Copy link
Collaborator

No description provided.

albertZhangTJ
albertZhangTJ commented Dec 17, 2022
View reviewed changes
src/sqlancer/postgres/ast/PostgresBinaryArithmeticOperation.java Outdated
@@ -58,15 +58,21 @@ public PostgresConstant apply(PostgresConstant left, PostgresConstant right) {
private String textRepresentation;

private static PostgresConstant applyBitOperation(PostgresConstant left, PostgresConstant right,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function name seems a bit confusing. Should it be applyBinaryOperation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, or perhaps applyBinaryArithmeticOperation - either would be better.

mrigger
mrigger reviewed Dec 18, 2022
View reviewed changes
Copy link
Contributor

@mrigger mrigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm wondering if we really need PQS support for floats for Postgres, as it might be difficult to get correct due to potential minor rounding differences. If we want to add support, we should make sure that it doesn't cause any false alarms (e.g., by testing corner cases).

src/sqlancer/postgres/ast/PostgresBinaryArithmeticOperation.java Outdated
@@ -58,15 +58,21 @@ public PostgresConstant apply(PostgresConstant left, PostgresConstant right) {
private String textRepresentation;

private static PostgresConstant applyBitOperation(PostgresConstant left, PostgresConstant right,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, or perhaps applyBinaryArithmeticOperation - either would be better.

src/sqlancer/postgres/ast/PostgresBinaryArithmeticOperation.java
@@ -58,15 +58,21 @@ public PostgresConstant apply(PostgresConstant left, PostgresConstant right) {
private String textRepresentation;

private static PostgresConstant applyBitOperation(PostgresConstant left, PostgresConstant right,
BinaryOperator<Long> op) {
BinaryOperator<Float> op) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using BinaryOperator<Float> in both an integer and floating-point context seems error-prone. Not sure if we should add another class instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I will handle this by adding common classes for these data types in a separate PR.

albertZhangTJ and others added 21 commits December 19, 2022 13:11
@albertZhangTJ
Override isEqual for Postgres::FloatConstant
fc1e002
@bajinsheng @albertZhangTJ
Escaping newlines
b47125a
@bajinsheng @albertZhangTJ
fix bug in CREATE TABLE
1a0803a
@bajinsheng @albertZhangTJ
random virtual/rtree table names generation (sqlancer#647)
e901cf2
@hanyisong @albertZhangTJ
add(databend): databend bugs (sqlancer#646)
a09403b 
Signed-off-by: Yisong Han <yisong8686@gmail.com>

Signed-off-by: Yisong Han <yisong8686@gmail.com>
@hawkingrei @albertZhangTJ
tidb: add more hint (sqlancer#649)
4c55501 
* tidb: add SHUFFLE_JOIN, BROADCAST_JOIN, LIMIT_TO_COP, MPP_1PHASE_AGG, MPP_2PHASE_AGG

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

* tidb: add SHUFFLE_JOIN, BROADCAST_JOIN, LIMIT_TO_COP, MPP_1PHASE_AGG, MPP_2PHASE_AGG

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

* improve code

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

* improve code

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@dependabot @albertZhangTJ
build(deps): bump spotbugs-maven-plugin from 4.7.2.1 to 4.7.3.0 (sqla…
1ff080f 
…ncer#608)

Bumps [spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.7.2.1 to 4.7.3.0.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](spotbugs/spotbugs-maven-plugin@spotbugs-maven-plugin-4.7.2.1...spotbugs-maven-plugin-4.7.3.0)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @albertZhangTJ
build(deps): bump mariadb-java-client from 3.0.8 to 3.1.0 (sqlancer#614)
ada5747 
Bumps [mariadb-java-client](https://github.com/mariadb-corporation/mariadb-connector-j) from 3.0.8 to 3.1.0.
- [Release notes](https://github.com/mariadb-corporation/mariadb-connector-j/releases)
- [Changelog](https://github.com/mariadb-corporation/mariadb-connector-j/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mariadb-corporation/mariadb-connector-j/commits)

---
updated-dependencies:
- dependency-name: org.mariadb.jdbc:mariadb-java-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @albertZhangTJ
build(deps): bump postgresql from 42.5.0 to 42.5.1 (sqlancer#620)
7e91479 
Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.5.0 to 42.5.1.
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](pgjdbc/pgjdbc@REL42.5.0...REL42.5.1)

---
updated-dependencies:
- dependency-name: org.postgresql:postgresql
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@bajinsheng @mrigger @albertZhangTJ
Add interface to return queries by oracles (sqlancer#648)
b45f2fd 
Co-authored-by: Manuel Rigger <rigger@nus.edu.sg>
@bajinsheng @albertZhangTJ
fix: broken grammar of LIKELIHOOD (sqlancer#650)
da53c8d
@hawkingrei @albertZhangTJ
tidb: turn off bug switch (sqlancer#638)
71c94c3 
* tidb: turn off bug switch

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

* improve code

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

* improve code

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

* improve code

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

* improve code

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

* improve code

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

* improve code

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@bajinsheng @albertZhangTJ
fix: broken grammar of aggreate in SQLite (sqlancer#651)
5d350fb
@bajinsheng @albertZhangTJ
Bump SQLite version to 3.40.0.0 (sqlancer#652)
8eef083 
* bump SQLite to 3.40.0.0

* Support RIGHT/FULL JOINs
@bajinsheng @albertZhangTJ
fix: temp table generation (sqlancer#653)
6a7c961
@bajinsheng @albertZhangTJ
opt: support new features in SQLite (sqlancer#654)
0d07948 
* opt: support maximum number of table/index

* opt: support explain interface
@bajinsheng @albertZhangTJ
fix: null pointer reference (sqlancer#656)
b0c3d70
@bajinsheng @albertZhangTJ
opt: some new features in CockroachDB (sqlancer#657)
9d96e31 
* opt: maximum number of tables/indexes in CockroachDB

* opt: support drop table/view

* opt: update Actions
@bajinsheng @albertZhangTJ
fix: connection string cockroachdb (sqlancer#658)
839b0b9
@bajinsheng @albertZhangTJ
fix: switch off vectorization cockroachdb (sqlancer#659)
aa2bd7b
@bajinsheng @albertZhangTJ
opt: maximum number of tables/indexes tidb
d4d40c5
@albertZhangTJ
Copy link
Collaborator Author

My apologies for my carelessness. I will update to try to handle the rounding error.

I will also add some test cases to validate the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrigger mrigger mrigger left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@albertZhangTJ @mrigger @bajinsheng @hanyisong @hawkingrei