Add cnosdb expect error and modify db schema #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add expect error and modify db schema
add expect error
mrigger
reviewed
Mar 1, 2023
| @@ -69,6 +69,8 @@ private CnosDBExpectedError() { | |||
| ERRORS.add( | |||
| "Coercion from [Utf8, Float64, Utf8] to the signature OneOf([Exact([Utf8, Int64]), Exact([LargeUtf8, Int64]), Exact([Utf8, Int64, Utf8]), Exact([LargeUtf8, Int64, Utf8]), Exact([Utf8, Int64, LargeUtf8]), Exact([LargeUtf8, Int64, LargeUtf8])]) failed."); | |||
| ERRORS.add("Coercion from"); | |||
| ERRORS.add("Build left right indices error"); | |||
There was a problem hiding this comment.
For new expected errors, I'd suggest adding them on a finer-grained basis (e.g., having errors for expression evaluations, specific kinds of statements, etc).
| @@ -69,9 +69,10 @@ public CnosDBConnection createDatabase(CnosDBGlobalState globalState) throws Exc | |||
| CnosDBClient client = new CnosDBClient(host, port, username, password, databaseName); | |||
| CnosDBConnection connection = new CnosDBConnection(client); | |||
| client.execute("DROP DATABASE IF EXISTS " + databaseName); | |||
| String createdb = "CREATE DATABASE " + databaseName + " WITH TTL '1000000' REPLICA 2"; | |||
There was a problem hiding this comment.
What does WITH TTL '1000000' mean? Do you think it might be useful to add a short comment why we override the default configuration?
|
Any updates on this? It would be great if we could merge the PR (which is now out-of-date with the base branch, so a merge would be necessary)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cnosdb expect error and modify db schema
