Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bug in reducer #901

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

oraluben
Copy link
Collaborator

@oraluben oraluben commented Dec 5, 2023

@@ -204,7 +204,7 @@ public FileWriter getReduceFileWriter() {
}
if (reduceFileWriter == null) {
try {
reduceFileWriter = new FileWriter(reduceFile, false);
reduceFileWriter = new FileWriter(reduceFile, true);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we'd better use false here. Otherwise, the reduce log would keep increasing.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual issue is at L495-497. I think the logger there is not for the newGlobalState

@suyZhong
Copy link

suyZhong commented Dec 6, 2023

Just a few suggestions,

  1. We could replace the currentFileWriter when reducing since we don't need to write to -cur.log anymore
  2. Currently the exception log (database.log) only shows DDL&DML statements after reducing. I hope except for the general "check reduce.log", I could also see the reduced query in it. We could somehow keep the error messages (Assertion when finding a bug) in the reproducer and add this message at here:
    throw new AssertionError("Found a potential bug, please check reducer log for detail.");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants