-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some bug in reducer #901
base: main
Are you sure you want to change the base?
Conversation
src/sqlancer/Main.java
Outdated
@@ -204,7 +204,7 @@ public FileWriter getReduceFileWriter() { | |||
} | |||
if (reduceFileWriter == null) { | |||
try { | |||
reduceFileWriter = new FileWriter(reduceFile, false); | |||
reduceFileWriter = new FileWriter(reduceFile, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we'd better use false here. Otherwise, the reduce log would keep increasing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual issue is at L495-497. I think the logger there is not for the newGlobalState
Just a few suggestions,
|
cc @suyZhong