Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Changes are not consistently applied to v2 and v3 #290

Closed
mbyczkowski opened this issue Mar 3, 2020 · 2 comments
Closed

Changes are not consistently applied to v2 and v3 #290

mbyczkowski opened this issue Mar 3, 2020 · 2 comments

Comments

@mbyczkowski
Copy link
Contributor

I have found a few cases were we have not been applying changes to either v2 or master branch (current v3 development). To make things clearer, I propose we only create PRs targeting master and then cherry-pick to v2 (when applicable):

  • If PR for v3 also makes sense for v2 (say a bug-fix or a backward-compatible feature), let's label the PR V2-Cherry-Pick (or something similar), so we know a cherry-pick should be made onto v2 (and a person merging should create a separate commit with cherry pick).
  • If PR is only to fix v2, then PR should be labeled accordingly, e.g. V2-Only.

Here's the list of (potential) discrepancies I have found to date:

master-only PRs:

v2-only PRs:

@csstaub
Copy link
Collaborator

csstaub commented Mar 3, 2020

I like this @mbyczkowski, let it be so.

This was referenced Mar 8, 2020
@mbyczkowski
Copy link
Contributor Author

Cool, I have created the labels and opened #291 and #292 to back-port and port-forward the missing changes. The remaining PR (#261) is being tracked already in #257.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants