This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Cherry-pick v2 PRs #292
Merged
Cherry-pick v2 PRs #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Mar 8, 2020
| }) | ||
| assert.Nil(t, err) | ||
| // Payload should be b64 encoded | ||
| assert.Len(t, data, len(b64TrueHeader.base64())+len(encodedPayload)+1) |
There was a problem hiding this comment.
mnd: Magic number: 1, in detected (from gomnd)
There was a problem hiding this comment.
we should probably disable gomnd in test files
| }) | ||
| assert.Nil(t, err) | ||
| // Payload should *not* be b64 encoded | ||
| assert.Len(t, data, len(b64FalseHeader.base64())+len(payload)+1) |
There was a problem hiding this comment.
mnd: Magic number: 1, in detected (from gomnd)
mbyczkowski
force-pushed
the
mbyczkowski/v3-cherry-picks
branch
from
bfac477
to
2009556
Compare
csstaub
approved these changes
Mar 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that a number of PRs, that were applicable to v3, had only been merged to v2 -- this issue has been documented in #290.
This PR brings the following changes to v3: