Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java 18 to CI build matrix #1237

Merged
merged 1 commit into from Apr 14, 2022
Merged

Add Java 18 to CI build matrix #1237

merged 1 commit into from Apr 14, 2022

Conversation

Egorand
Copy link
Collaborator

@Egorand Egorand commented Apr 14, 2022

Is it supported?

@JakeWharton
Copy link
Member

Note that this is the wrong way to test multiple versions and we should migrate to building on a single version and merely testing on multiple: square/retrofit#3713.

@Egorand
Copy link
Collaborator Author

Egorand commented Apr 14, 2022

Makes sense, can fix it up in a followup!

@Egorand Egorand merged commit 9d463fc into master Apr 14, 2022
@Egorand Egorand deleted the egor/220414/java-18 branch April 14, 2022 17:59
@Egorand
Copy link
Collaborator Author

Egorand commented Apr 20, 2022

@JakeWharton the downside of this solution is that I can't really run gw clean build locally anymore as it'll start pulling tons of JDKs. Is there a workaround?

@JakeWharton
Copy link
Member

We could remove them from the check task and instead use a custom aggregating task that's only run on CI or explicitly locally.

@JakeWharton
Copy link
Member

Also worth noting those JDKs that are downloaded are only done once (and only when missing on the system). So once you pay the cost it'll be back to being extremely fast.

@Egorand
Copy link
Collaborator Author

Egorand commented Apr 20, 2022

I'm getting toolchain download errors, seemingly cause it can't find JDKs of specific versions for M1. I think I'd prefer a separate task for the CI, that can also be called explicitly on a dev machine if needed - I'll send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants