Update dependencies #1240
Merged
Update dependencies #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Egorand
commented
Apr 19, 2022
Egorand
commented
- Kotlin 1.6.21: https://github.com/JetBrains/kotlin/releases/tag/v1.6.20
- KSP 1.6.20-1.0.5: https://github.com/google/ksp/releases/tag/1.6.20-1.0.5
- Dokka 1.6.20: https://github.com/Kotlin/dokka/releases/tag/v1.6.20
- KCT 1.4.8: https://github.com/tschuchortdev/kotlin-compile-testing/releases/tag/1.4.8
Egorand
commented
Apr 19, 2022
| @@ -300,8 +300,8 @@ class TestProcessorTest { | |||
| public class Example { | |||
| public fun aliases( | |||
| aliasedName: String, | |||
| genericAlias: List<String>, | |||
| genericMapAlias: Map<Int, String>, | |||
| genericAlias: List, | |||
There was a problem hiding this comment.
@ZacSweers this looks like a regression in KSP?
There was a problem hiding this comment.
yes we need to fix something on the kotlinpoet side. Behavior change rather than a regression
There was a problem hiding this comment.
I can take a look.
There was a problem hiding this comment.
@ZacSweers PTAL! abbcc17
|
Great points @ting-yuan, thanks! @ZacSweers I can fix these issues in a followup PR, would prefer merging this one as is to not increase the scope further. |
ZacSweers
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.