Add support for context receivers @PropertySpec and fix issues with annotations #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2022 09:44
Prevent context receivers on accessors Add FunSpec tests: - Annotated function with context receiver - Accessor with context receiver Add context receivers to PropertySpec Add PropertySpec tests: - Var with context receiver - Val without getter with context receiver - Val with context receiver - Annotated val with context receiver
Egorand
requested changes
May 8, 2022
kotlinpoet/src/main/java/com/squareup/kotlinpoet/PropertySpec.kt
Outdated
Show resolved
Hide resolved
kotlinpoet/src/test/java/com/squareup/kotlinpoet/PropertySpecTest.kt
Outdated
Show resolved
Hide resolved
kotlinpoet/src/test/java/com/squareup/kotlinpoet/PropertySpecTest.kt
Outdated
Show resolved
Hide resolved
Update tests for vars with context receivers without custom accessors Add test for var with context receivers and custom accessors Fix code style
Egorand
approved these changes
May 9, 2022
kotlinpoet/src/main/java/com/squareup/kotlinpoet/PropertySpec.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Egor Andreevich <github@egorand.dev>
|
@Egorand will the snapshot repository be updated with this? I really need this fix to publish my library |
|
Yes! As soon as it's merged CI will publish a fresh snapshot. |
|
@Egorand Please recheck as I just accepted your suggestion earlier today and had to update the tests right now. Thank you! |
|
Merging, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #1244, here is a PR to add support for context receivers @
PropertySpec.Proposed Changes
contextReceiversavailable inPropertySpecbuilderFunSpecto throw exception when a context receiver is added to an accessor