Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug caused by too long return expressions #1256

Merged
merged 12 commits into from Jun 1, 2022
Merged

Conversation

zsqw123
Copy link
Contributor

@zsqw123 zsqw123 commented May 29, 2022

@zsqw123 zsqw123 requested a review from Egorand May 31, 2022 04:07
Copy link
Collaborator

@Egorand Egorand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I just added a few suggestions on the style.

Also, please sign our CLA before I can merge your PR.

@zsqw123 zsqw123 requested review from Egorand June 1, 2022 12:06
@Egorand
Copy link
Collaborator

Egorand commented Jun 1, 2022

Merging, thanks again!

@Egorand Egorand merged commit 35da0d5 into square:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kotlinpoet will fail if it returns an expression that is too long
3 participants