Update kotlinx-metadata APIs for changes #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Egorand
approved these changes
Dec 11, 2023
|
Yeah build that habit, Egor! |
|
@ZacSweers this would need to be rebased now that we've merged the 0.9.0 version bump: #1830. |
ZacSweers
changed the title
JakeWharton
approved these changes
Apr 17, 2024
Comment on lines
1
to
7
| public final class com/squareup/kotlinpoet/metadata/KotlinPoetMetadata { | ||
| public static final fun readKotlinClassMetadata (Lkotlin/Metadata;)Lkotlinx/metadata/jvm/KotlinClassMetadata; | ||
| public static final fun toKmClass (Ljava/lang/Class;)Lkotlinx/metadata/KmClass; | ||
| public static final fun toKmClass (Ljavax/lang/model/element/TypeElement;)Lkotlinx/metadata/KmClass; | ||
| public static final fun toKmClass (Lkotlin/Metadata;)Lkotlinx/metadata/KmClass; | ||
| public static final fun toKmClass (Lkotlin/reflect/KClass;)Lkotlinx/metadata/KmClass; | ||
| public static final fun readKotlinClassMetadata (Lkotlin/Metadata;Z)Lkotlinx/metadata/jvm/KotlinClassMetadata; | ||
| public static final fun toKmClass (Ljava/lang/Class;Z)Lkotlinx/metadata/KmClass; | ||
| public static final fun toKmClass (Ljavax/lang/model/element/TypeElement;Z)Lkotlinx/metadata/KmClass; | ||
| public static final fun toKmClass (Lkotlin/Metadata;Z)Lkotlinx/metadata/KmClass; | ||
| public static final fun toKmClass (Lkotlin/reflect/KClass;Z)Lkotlinx/metadata/KmClass; | ||
| } |
There was a problem hiding this comment.
None of these functions have KotlinPoet types as parameter types or return types. Do they need to be public?
There was a problem hiding this comment.
We've historically offered a bit of a superset of APIs here with some helpers to make KM usage easier. It's become less necessary now though that the API on their side has caught up. Let me take a pass at cleaning these up in a followup PR?
interop/kotlinx-metadata/src/main/kotlin/com/squareup/kotlinpoet/metadata/KotlinPoetMetadata.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changelog yet: https://github.com/JetBrains/kotlin/blob/master/libraries/kotlinx-metadata/jvm/ChangeLog.md