fix(text): prevent always running detect text alignment #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -227,10 +227,14 @@ export default { | |||
| * Detect if the text is center aligned and add left padding | |||
| * to balance out the letter spacing | |||
| */ | |||
| detectAlignCenter() { | |||
| detectAlignCenterAndLetterSpacing() { | |||
| if (!this.letterSpacing && !this.resolvedLetterSpacing) { | |||
There was a problem hiding this comment.
i don't think you need the !this.letterSpacing here, I think just !this.resolvedLetterSpacing is enough (since it checks this.letterSpacing under the hood).
pretzelhammer
approved these changes
Mar 26, 2024
|
the CI checks failed because they ran against your repo (wkashdan/maker) instead of the main repo (square/maker). I added you to the Maker Contributors team so you should now have permissions to make the PR directly on square/maker where the CI checks can run properly. |
|
Closing this in favor of #579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the problem this PR addresses
This pull request is meant to improve browser performance of the Text component. The current implementation causes the browser to recompute actual styles each time a text component is mounted and/or updated. This occurs only to fix an issue with letter spacing.
Describe the changes in this PR
This PR ensure the logic to detect center styling only runs if custom letter spacing is passed in to the component, otherwise there is no need to run this.
Other information
This issue frequently causes Safari to do a force layout calculation which is inefficient.