Comments on loom test (#8340)

square · Apr 6, 2024 · dba8478 · dba8478
1 parent b4614e4
commit dba8478
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/container-tests/src/test/java/okhttp3/containers/BasicLoomTest.kt b/container-tests/src/test/java/okhttp3/containers/BasicLoomTest.kt
@@ -49,6 +49,8 @@ class BasicLoomTest {
   @RegisterExtension
   val platform = PlatformRule()
 
+  // Use mock server so we are strictly testing OkHttp client only in this test.
+  // We should test MockWebServer later.
   @Container
   val mockServer: MockServerContainer = MockServerContainer(MOCKSERVER_IMAGE)
 
@@ -71,6 +73,8 @@ class BasicLoomTest {
 
     executor = newVirtualThreadPerTaskExecutor()
 
+    // Capture non-deterministic but probable sysout warnings of pinned threads
+    // https://docs.oracle.com/en/java/javase/21/core/virtual-threads.html
     System.setOut(PrintStream(capturedOut))
   }