Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclusive Cache Lock #8209

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
8674a8b
Cache Lock
yschimke Jan 20, 2024
c3df60f
Merge branch 'master' into cache_singleton
yschimke Apr 1, 2024
166a255
Merge branch 'master' into cache_singleton
yschimke Apr 1, 2024
b02738d
Rework
yschimke Apr 1, 2024
ac0cc79
Rework
yschimke Apr 1, 2024
2525edf
Add test
yschimke Apr 1, 2024
7072358
Cleanup
yschimke Apr 1, 2024
5ca131f
Activate missed test
yschimke Apr 1, 2024
0a2fbb6
Cleanup
yschimke Apr 1, 2024
c9db9d4
Avoid checking on non system file systems
yschimke Apr 1, 2024
97e566b
Revert "Avoid checking on non system file systems"
yschimke Apr 1, 2024
ee1daa6
Avoid failing on dns tests
yschimke Apr 1, 2024
3041258
Adding a test
yschimke Apr 2, 2024
7faba3e
Fixes
yschimke Apr 2, 2024
44d3640
Test on more platforms
yschimke Apr 3, 2024
792b689
Cleanup
yschimke Apr 3, 2024
5117f46
Merge branch 'master' into cache_singleton
yschimke Apr 3, 2024
a922b1d
Cleanup
yschimke Apr 3, 2024
e24e146
Fixes
yschimke Apr 6, 2024
04c057f
Fixes
yschimke Apr 6, 2024
5c6c60d
Cache fixes
yschimke Apr 6, 2024
12b7eb9
Cache fixes
yschimke Apr 6, 2024
ae3830d
Cache fixes
yschimke Apr 6, 2024
99a5ee5
Cache fixes
yschimke Apr 6, 2024
cc97769
Cache fixes
yschimke Apr 6, 2024
6dbb03f
Fix test
yschimke Apr 6, 2024
19be22b
Merge branch 'refs/heads/master' into cache_singleton
yschimke Apr 6, 2024
feafff9
Fix test
yschimke Apr 6, 2024
72359a6
avoid windows for now
yschimke Apr 6, 2024
b76aa7f
Fix or skip on windows
yschimke Apr 7, 2024
89e9d80
cleanup
yschimke Apr 7, 2024
28025e2
skip on windows
yschimke Apr 7, 2024
fa707bc
Update DuplexTest.kt
yschimke Apr 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
44 changes: 44 additions & 0 deletions okhttp/src/main/kotlin/okhttp3/internal/cache/CacheLock.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
package okhttp3.internal.cache
yschimke marked this conversation as resolved.
Show resolved Hide resolved

import android.annotation.SuppressLint
import java.io.Closeable
import java.nio.channels.FileChannel
import java.nio.file.StandardOpenOption
import java.util.Collections
import okhttp3.internal.platform.Platform
import okio.FileSystem
import okio.Path

internal object CacheLock {
private val openCaches = Collections.synchronizedMap(mutableMapOf<Path, Exception>())

fun openLock(fileSystem: FileSystem, directory: Path): Closeable {
return if (fileSystem == FileSystem.SYSTEM && !Platform.isAndroid) {
yschimke marked this conversation as resolved.
Show resolved Hide resolved
fileSystemLock(directory)
} else {
inMemoryLock(directory)
}
}

@SuppressLint("NewApi")
fun inMemoryLock(directory: Path): Closeable {
// TODO solution for Android N?
val existing = openCaches.putIfAbsent(directory, Exception("CacheLock($directory)"))
yschimke marked this conversation as resolved.
Show resolved Hide resolved
if (existing != null) {
throw IllegalStateException("Cache already open at '$directory'", existing)
}
return okio.Closeable {
openCaches.remove(directory)
}
}

@SuppressLint("NewApi")
fun fileSystemLock(directory: Path): Closeable {
yschimke marked this conversation as resolved.
Show resolved Hide resolved
val lockFile = directory / "lock"
val channel = FileChannel.open(lockFile.toNioPath(), StandardOpenOption.APPEND)

return okio.Closeable {
channel.close()
}
}
}
7 changes: 7 additions & 0 deletions okhttp/src/main/kotlin/okhttp3/internal/cache/DiskLruCache.kt
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import java.io.EOFException
import java.io.Flushable
import java.io.IOException
import okhttp3.internal.assertThreadHoldsLock
import okhttp3.internal.cache.CacheLock.openLock
import okhttp3.internal.cache.DiskLruCache.Editor
import okhttp3.internal.closeQuietly
import okhttp3.internal.concurrent.Task
Expand Down Expand Up @@ -95,6 +96,8 @@ class DiskLruCache(
/** Used for asynchronous journal rebuilds. */
taskRunner: TaskRunner,
) : Closeable, Flushable {
lateinit var cacheLock: Closeable

internal val fileSystem: FileSystem =
object : ForwardingFileSystem(fileSystem) {
override fun sink(
Expand Down Expand Up @@ -242,6 +245,8 @@ class DiskLruCache(

civilizedFileSystem = fileSystem.isCivilized(journalFileBackup)

cacheLock = openLock(fileSystem, directory)
yschimke marked this conversation as resolved.
Show resolved Hide resolved

// Prefer to pick up where we left off.
if (fileSystem.exists(journalFile)) {
try {
Expand Down Expand Up @@ -705,6 +710,8 @@ class DiskLruCache(
return
}

cacheLock.close()

// Copying for concurrent iteration.
for (entry in lruEntries.values.toTypedArray()) {
if (entry.currentEditor != null) {
Expand Down