Cache URL Override #8234
Merged
Cache URL Override #8234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
reviewed
Mar 21, 2024
okhttp-dnsoverhttps/src/main/kotlin/okhttp3/dnsoverhttps/DnsOverHttps.kt
Show resolved
Hide resolved
swankjesse
reviewed
Mar 21, 2024
okhttp-dnsoverhttps/src/main/kotlin/okhttp3/dnsoverhttps/DnsOverHttps.kt
Show resolved
Hide resolved
swankjesse
approved these changes
Mar 21, 2024
okhttp-dnsoverhttps/src/main/kotlin/okhttp3/dnsoverhttps/DnsOverHttps.kt
Show resolved
Hide resolved
okhttp-dnsoverhttps/src/test/java/okhttp3/dnsoverhttps/DnsOverHttpsTest.kt
Show resolved
Hide resolved
| var recordedRequest = server.takeRequest() | ||
| assertThat(recordedRequest.method).isEqualTo("POST") | ||
| assertThat(recordedRequest.path) | ||
| .isEqualTo("/lookup?ct") |
There was a problem hiding this comment.
Off-topic: we’re naughty for having a field called path that contains a path and a query. Thanks for confirming that we use the right URL for these!
swankjesse
reviewed
Mar 21, 2024
| @@ -1048,6 +1049,7 @@ public class okhttp3/Request$Builder { | |||
| public fun addHeader (Ljava/lang/String;Ljava/lang/String;)Lokhttp3/Request$Builder; | |||
| public fun build ()Lokhttp3/Request; | |||
| public fun cacheControl (Lokhttp3/CacheControl;)Lokhttp3/Request$Builder; | |||
| public final fun cacheUrlOverride (Lokhttp3/HttpUrl;)Lokhttp3/Request$Builder; | |||
There was a problem hiding this comment.
Note that we’re not adding OkHttpExperimentalApi on this, and so we’re committing to this exact API and name. I’m okay with that.
There was a problem hiding this comment.
Should we reconsider as a policy for new API?
Co-authored-by: Jesse Wilson <jwilson@squareup.com>
Co-authored-by: Jesse Wilson <jwilson@squareup.com>
Co-authored-by: Jesse Wilson <jwilson@squareup.com>
Co-authored-by: Jesse Wilson <jwilson@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minimal change to allow a cacheUrlOverride on request for the following examples
It is implemented almost entirely within CacheInterceptor, mutating the request/response that Cache sees to avoid a broader change such as supporting POSTs.
Addresses #8211 also #8113