Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acquire fewer locks in TaskRunner #8394

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Acquire fewer locks in TaskRunner #8394

wants to merge 2 commits into from

Commits on Apr 29, 2024

  1. Acquire fewer locks in TaskRunner 

    Previously each run did this:

 - acquire a lock to take a task
 - acquire a lock to finish a task
 - if crashed, acquire a lock to start a new thread

So to run 10 tasks without any crashes, we'd acquire
the lock 20 times.

With this update, we do this:

 - acquire a lock to take the first task
 - acquire a lock to release task N and take task N + 1

So to run 10 tasks without any crashes, we now acquire
the lock 11 times.
    @swankjesse
    swankjesse committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6a757ac View commit details
    Browse the repository at this point in the history

  2. Spotless

    @swankjesse
    swankjesse committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    97f57b2 View commit details
    Browse the repository at this point in the history