Introduces fun Screen.deepMap(Screen): Screen
#1092
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces and uses `Screen`-specific subtypes of the `Container` and `Wrapper` interfaces. This allows the inroduction of `Screen.deepMap()`, which allows us to apply a transformation to the "real" `Screen`s collected in a `Container`, no matter how deeply wrapped they are.
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
RBusarow
reviewed
Nov 16, 2023
| package com.squareup.workflow1.ui | ||
|
|
||
| @WorkflowUiExperimentalApi | ||
| public interface VisualHolder<in RenderingT, out VisualT> { |
There was a problem hiding this comment.
It seems like some of the kdoc for VisualFactory.createOrNull should be here as well.
There was a problem hiding this comment.
Uh oh. I think this and VisualHolder leaked in from an unrelated PR.
rjrjr
commented
Nov 16, 2023
| */ | ||
| @WorkflowUiExperimentalApi | ||
| public fun Screen.deepMap(transform: (Screen) -> Screen): Screen { | ||
| return if (this is ScreenContainer<*>) { |
There was a problem hiding this comment.
You know what? I don't know that ScreenContainer is actually necessary for this. I'm going to put this PR back into draft.
-
ScreenContainerprobably isn't necessary.
rjrjr
commented
Nov 16, 2023
| context: ContextT, | ||
| environment: ViewEnvironment, | ||
| getFactory: (ViewEnvironment) -> VisualFactory<ContextT, Any, VisualT> | ||
| ): VisualHolder<RenderingT, VisualT>? |
There was a problem hiding this comment.
- Unused, did this leak in from the work for Wrapper renderings introduce an extra AndroidView unnecessarily when the wrapped rendering's factory is a ComposeScreenViewFactory. #546?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces and uses
Screen-specific subtypes of theContainerandWrapperinterfaces. This allows the inroduction ofScreen.deepMap(), which allows us to apply a transformation to the "real"Screens collected in aContainer, no matter how deeply wrapped they are.