Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not change Workflow API for COmpose #833

Draft
wants to merge 1 commit into
base: sedwards/compose-with-return-rendering
Choose a base branch
from
Draft

Do not change Workflow API for COmpose #833

wants to merge 1 commit into from

Conversation

steve-the-edwards
Copy link
Contributor

No description provided.

@steve-the-edwards
Copy link
Contributor Author

This looks harder to do than originally thought. Not a rabbit hole that makes sense to go down now as we would have to understand more about the "Data Anchor" and why it is wrong when using the forced Compose call method.

@zach-klippenstein had recommendation which I will record for posterity:

I would start by attaching a debugger, seeing what’s causing that anchor to be calculated as negative, and working backwards from there to see how it gets in a bad state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zach-klippenstein zach-klippenstein Awaiting requested review from zach-klippenstein zach-klippenstein will be requested when the pull request is marked ready for review zach-klippenstein is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@steve-the-edwards