Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JetBrain's new kotlin binary compatibility validator to start tracking changes to our ABI. #948

Merged
merged 1 commit into from Feb 10, 2020

Conversation

zach-klippenstein
Copy link
Collaborator

Ignores all leaf sample projects individually, wildcards are not supported (see Kotlin/binary-compatibility-validator#3).

Closes #243.

@zach-klippenstein zach-klippenstein added this to Needs review in Workflow (Kotlin) via automation Feb 10, 2020
Copy link
Collaborator

@tehras tehras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice plugin!

kotlin/build.gradle Outdated Show resolved Hide resolved
…cking changes to our ABI.

Ignores all leaf sample projects individually, wildcards are not supported
(see Kotlin/binary-compatibility-validator#3).

Closes #243.
@zach-klippenstein zach-klippenstein merged commit 8827ab1 into master Feb 10, 2020
Workflow (Kotlin) automation moved this from Needs review to Done Feb 10, 2020
@zach-klippenstein zach-klippenstein deleted the zachklipp/binary-compatibility branch February 10, 2020 17:30
@zach-klippenstein
Copy link
Collaborator Author

This tool doesn't process Android modules unfortunately. Filed: Kotlin/binary-compatibility-validator#4

@zach-klippenstein
Copy link
Collaborator Author

Latest master supports android modules! Will update dependency and API dump once v0.1.2 is released.

@zach-klippenstein zach-klippenstein added the kotlin Affects the Kotlin library. label Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kotlin Affects the Kotlin library.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Should we enforce binary compatibility for Kotlin libraries?
2 participants