testRandomUuid: use cppunit exception tests #1814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not hand-roll tests for exception-throwing code, use the CppUnit primitives instead
|
Followup to PR #1811 |
kinkie
added
the
backport-to-v6
rousskov
previously approved these changes
May 18, 2024
| continue; // success, caught a malformed UUID | ||
| } | ||
| CPPUNIT_FAIL("failed to reject an invalid UUID"); | ||
| CPPUNIT_ASSERT_THROW(RandomUuid uuid(id.second), TextException); |
There was a problem hiding this comment.
I am a bit worried that uuid is now seemingly unused, but since compilers do not seem to think so, I am OK with the current PR code.
FWIW, I would prefer something more explicit like the code below, but I do not know whether it would work.
Suggested change
| CPPUNIT_ASSERT_THROW(RandomUuid uuid(id.second), TextException); | |
| CPPUNIT_ASSERT_THROW((void)RandomUuid(id.second), TextException); |
There was a problem hiding this comment.
I expect the compilers are smart enough to notice that the RandomUuid has external side effects on the shared/static RNG engine.
rousskov
added
S-waiting-for-author
yadij
previously approved these changes
May 19, 2024
yadij
added
M-cleared-for-merge
|
Moving test_http_range changes to their own PR (#1816). |
rousskov
approved these changes
May 20, 2024
rousskov
added
the
S-waiting-for-reviewer
yadij
approved these changes
May 22, 2024
yadij
removed
the
S-waiting-for-reviewer
squid-anubis
pushed a commit
that referenced
this pull request
May 22, 2024
Do not hand-roll tests for exception-throwing code
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
May 23, 2024
Do not hand-roll tests for exception-throwing code
|
queued for backport to v6 |
squidadm
removed
the
backport-to-v6
yadij
pushed a commit
that referenced
this pull request
May 23, 2024
Do not hand-roll tests for exception-throwing code
kinkie
added a commit
to kinkie/squid
that referenced
this pull request
Jun 2, 2024
Do not hand-roll tests for exception-throwing code
kinkie
added a commit
to kinkie/squid
that referenced
this pull request
Jun 9, 2024
Do not hand-roll tests for exception-throwing code
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not hand-roll tests for exception-throwing code