Fix mermaid Entity-Relationship-Diagram attribute colors #4984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
squidfunk
requested changes
Feb 7, 2023
| @@ -30,7 +30,7 @@ | |||
|
|
|||
| // Colors | |||
| --md-mermaid-edge-color: var(--md-code-fg-color); | |||
| --md-mermaid-node-bg-color: var(--md-accent-fg-color--transparent); | |||
There was a problem hiding this comment.
Okay, so this is actually a pretty fundamental change:
Before:
Now:
I'm afraid I don't like the changes, and expect many users to complain since they're quite fundamental. Could you please check if there's another solution? Unfortunately, this solution can't be merged.
|
Superseded by f759841. The commit fixes the issue without changing all styles:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4975
I went through all diagram types covered with examples - there was nothing else significant missing, so nothing more to fix than the issue I reported initially.