Bumped mermaid version to 10.5.0 #6175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, have you discussed bumping Mermaid with @squidfunk? I cannot seem to find a discussion on this. Apologies if I have missed something. There would need to be a review as to whether this will not break things before a request to bump the version can be accepted. |
|
Yeah, so I screwed up. Buming over major versions will not work like 99% of the time, and I sadly haven't won the dependency lottery. 😂. Next time I'll test before publishing a pr... Im sorry |
|
Thanks for the PR! However, as you noted, this PR does not work, as it is blocked by #5758. Unfortunately, more work needs to be done to support Mermaid 10 than simply replacing the version number. Closing as not mergable. |
|
Yeah there was this esm-only problem #5193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.