Add MixedBooleanOperatorSniff #3205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
force-pushed
the
mixed-boolean-operator
branch
from
99a0f16
to
7b2ed42
Compare
|
I was going through the list of my open PRs: I'm seeing that this PR was assigned to a project / to the idea bank. How will this process further? I don't plan on making any more changes, unless you see issues during review. |
|
Sorry this hasn't moved. I've been prioritising bug fixes and support for newer PHP versions so I haven't looked into this yet. |
This comment has been minimized.
This comment has been minimized.
TimWolla
force-pushed
the
mixed-boolean-operator
branch
from
7b2ed42
to
136509f
Compare
TimWolla
force-pushed
the
mixed-boolean-operator
branch
from
136509f
to
ce61077
Compare
TimWolla
force-pushed
the
mixed-boolean-operator
branch
from
ce61077
to
22cf1f7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
TimWolla
force-pushed
the
mixed-boolean-operator
branch
from
22cf1f7
to
5ed8231
Compare
TimWolla
force-pushed
the
mixed-boolean-operator
branch
from
5ed8231
to
efd252b
Compare
TimWolla
force-pushed
the
mixed-boolean-operator
branch
from
efd252b
to
1036366
Compare
TimWolla
force-pushed
the
mixed-boolean-operator
branch
2 times, most recently
from
38061b2
to
d5292ed
Compare
TimWolla
force-pushed
the
mixed-boolean-operator
branch
from
d5292ed
to
a2d3504
Compare
11 tasks
|
FYI: this new sniff is included in today's PHP_CodeSniffer 3.9.0 release. As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 馃憢
This is my first contribution to PHP CodeSniffer. This PR adds a sniff that detects mixed boolean operators (
&&,||) within a single expression without making precedence clear using parentheses.I hope I did not miss an existing sniff that already does what I want this sniff to do. Please also let me know if I violated any written or unwritten rules regarding the namespace structure, code formatting, commit messages, etc or if you think I missed some edge case within my unit test.