Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct link in pull request template #3838

Closed
wants to merge 1 commit into from

Conversation

fredden
Copy link
Contributor

@fredden fredden commented May 26, 2023

Description

The link in the pull request template currently goes to https://github.com/squizlabs/PHP_CodeSniffer/compare/.github/CONTRIBUTING.md while creating a pull request, and https://github.com/squizlabs/PHP_CodeSniffer/pull/.github/CONTRIBUTING.md (which redirects to the first) afterwards. We could change the link to ../blob/HEAD/CONTRIBUTING.md (or ../blob/master/CONTRIBUTING.md) if we want to keep it relative; feel free to adjust this pull request if that's preferred.

Note too that the URL will need to be updated if #3830 gets merged before this, or as part of #3830 if this gets merged before that.

Suggested changelog entry

None required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.
  • [Required for new files] I have added any new files to the package.xml file.

Copy link
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd adjusted this template at the same time as creating/updating & moving the CONTRIBUTING doc, so I took a leap of faith that PR #3830 would/will be merged as well. Once that is merged, the link should work correctly ;-)

(and if it doesn't, let's update it after PR #3830 to prevent having to do yet another follow-up PR)

@fredden
Copy link
Contributor Author

fredden commented Dec 4, 2023

@fredden fredden closed this Dec 4, 2023
@fredden fredden deleted the pull-request-template branch December 4, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants