Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add position input #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

andrenarchy
Copy link

Fixes #54.

@srggrs
Copy link
Owner

srggrs commented Oct 6, 2021

Hi @andrenarchy thanks for this! Did you tested?

@andrenarchy
Copy link
Author

Yes, I tested this both with position: bottom and without the position input (in which case the request for moving the card is not made so it's backwards-compatible).

@javierm
Copy link

javierm commented Jul 21, 2022

Hi, @srggrs. I'm interested in this feature since we like prioritizing pull requests from top to bottom and we give less priority to the most recent ones. Is there anything I can help with? Maybe testing this pull request?

@srggrs
Copy link
Owner

srggrs commented Jul 27, 2022

Hi, @srggrs. I'm interested in this feature since we like prioritizing pull requests from top to bottom and we give less priority to the most recent ones. Is there anything I can help with? Maybe testing this pull request?

Please go on and test this functionality thx!

@javierm
Copy link

javierm commented Aug 22, 2022

Hi, @srggrs.

I've tested the andrenarchy/assign-one-project-github-action@master action. Everything seems to work as expected:

  • No parameter: cards are added to the top
  • position: "top": cards are added to the top
  • position: "bottom": cards are added to the top and then moved to the bottom
  • position: "after:<card_id>": cards are added to the top and then moved after the referenced card
  • position: "after:<non_existent_card_id>": cards are added to the top

Out of the (about 15?) tests I've done, only once I've seen a strange behavior: a card was added to the top, then moved to the bottom, and then moved to the top again. I wonder whether it was a mere glitch on github and maybe after refreshing the page the card would have been at the bottom (as expected) 🤔.

Here's a video showing one of the tests: in this case, draft pull requests are added to the top of the "doing" column (no position parameter) and regular pull requests are added to the bottom of the "reviewing" column (position: "bottom"). Even if there are only two pull requests per column in the video, I've also done tests with more pull requests and it worked fine as well.

kanban_position.webm

Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: specify position of card in column
3 participants