This repository has been archived by the owner on May 12, 2021. It is now read-only.
Make it possible to navigate with mouse forward/back buttons in Linux #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergelypolonkai
force-pushed
the
linux-mouse-navigation
branch
from
f3cf21b
to
b75d6e4
Compare
|
I'm really looking forward to this! Regarding "it will also be solved within Electron itself", do you know when that's planned or when we should expect it from upstream? |
|
I don’t, they just have a PR which is merged 2 months ago. Probably at the next release? |
|
I can't test this because I don't have a linux desktop handy right now, but code looks good. @christianbundy feel free to merge this if it works! |
|
It works! I've never actually used my mouse's forward and back buttons, but after taking this branch for a spin I can confirm that both my mouse buttons and this branch work as intended. Merging now, thanks @gergelypolonkai! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #487 (although it seems it will also be solved within Electron itself.)