Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint and markdownlint-cli to latest available version. #21

Merged
merged 3 commits into from Jan 27, 2021

Conversation

xydesa
Copy link
Collaborator

@xydesa xydesa commented Jan 25, 2021

Signed-off-by: Alexander Xydes alexander.xydes@navy.mil

Signed-off-by: Alexander Xydes <alexander.xydes@navy.mil>
@xydesa xydesa requested review from denewiler and removed request for denewiler January 25, 2021 20:20
…ent directory used for linting because eslint no longer supports global installs.

Signed-off-by: Alexander Xydes <alexander.xydes@navy.mil>
@xydesa
Copy link
Collaborator Author

xydesa commented Jan 27, 2021

Based on this stackoverflow post, and that newer versions of eslint do not support global installs (see links below) I changed the install location for most npm packages to the parent directory of the CWD in github actions.

https://eslint.org/docs/user-guide/migrating-to-6.0.0#package-loading-simplification
eslint/rfcs#47
eslint/eslint#13685

@xydesa xydesa requested a review from denewiler January 27, 2021 18:56
…ies.

Signed-off-by: Alexander Xydes <alexander.xydes@navy.mil>
@xydesa xydesa merged commit e7a1c75 into sscpac:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants