Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update continuous integration workflow configurations. #52

Closed
wants to merge 5 commits into from

Conversation

xydesa
Copy link
Collaborator

@xydesa xydesa commented Jan 30, 2023

No description provided.

@xydesa xydesa requested a review from denewiler January 30, 2023 22:20
.github/workflows/tests.yaml Outdated Show resolved Hide resolved
.github/workflows/tests.yaml Outdated Show resolved Hide resolved
.github/workflows/tests.yaml Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #52 (a1cdc58) into main (401842d) will decrease coverage by 1.80%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              main      #52      +/-   ##
===========================================
- Coverage   100.00%   98.20%   -1.80%     
===========================================
  Files            7        7              
  Lines          335      335              
===========================================
- Hits           335      329       -6     
- Misses           0        6       +6     
Impacted Files Coverage Δ
.../statick_web/plugins/tool/stylelint_tool_plugin.py 90.00% <0.00%> (-10.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xydesa
Copy link
Collaborator Author

xydesa commented Jan 30, 2023

@denewiler it seems like the issue with the failing test: https://github.com/sscpac/statick-web/actions/runs/4048849626/jobs/6964571593
may be related to this ticket in stylelint: stylelint/stylelint#6525
fixed in this PR: stylelint/stylelint#6547

does that make sense to you?

If so, we may need to wait for a new release of stylelint.

@xydesa
Copy link
Collaborator Author

xydesa commented Jan 30, 2023

@denewiler it seems like the issue with the failing test: https://github.com/sscpac/statick-web/actions/runs/4048849626/jobs/6964571593 may be related to this ticket in stylelint: stylelint/stylelint#6525 fixed in this PR: stylelint/stylelint#6547

does that make sense to you?

If so, we may need to wait for a new release of stylelint.

nvermind, it looks like it might be more related to this: stylelint/stylelint#1973

also, switching to the same local installation as the estlint configs seems to have fixed the issue.

@xydesa xydesa closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants