PipeStream bug fixes #1070
Closed
PipeStream bug fixes #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensigvardsson
commented
Jan 25, 2023
jorgensigvardsson
commented
- Handle non-zero offsets in Read(byte[], int, int): trivial change - drop the non-zero check, and use the offset in the target buffer index.
- Blocking bug: Don't block the pipe if available data is less than what's in the buffer. It may the case that the remote party is not sending, because it's waiting for data from us!
* Handle non-zero offsets in Read(byte[], int, int): trivial change - drop the non-zero check, and use the offset in the target buffer index. * Blocking bug: Don't block the pipe if available data is less than what's in the buffer. It may the case that the remote party is not sending, because it's waiting for data from us!
…en terminated already!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.