Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The toString() check now supports array fields #227

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

ekoutanov
Copy link
Collaborator

The best-practice for writing toString() methods containing array types is to use Arrays.toString() to print arrays, rather than default to the default implementation, which just prints the object reference. This change supports this.

@ekoutanov
Copy link
Collaborator Author

These Codacy checks aren't terribly effective, me thinks.

@@ -83,18 +80,8 @@ public static boolean isFinal(final Field field) {
.collect(Collectors.toList());
}

private static void makeModifiable(final Field field) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about this change

build.gradle Outdated
vcsUrl = 'https://github.com/sta-szek/pojo-tester.git'
userOrg = "obsidiandynamics"
desc = 'POJO testing library'
websiteUrl = 'https://github.com/obsidiandynamics/pojo-tester'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert pls :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants