fix equals/hashcode on class with inner class #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sta-szek
reviewed
Jun 8, 2020
| @@ -53,7 +53,7 @@ public T increaseValue(final T value) { | |||
| return (T) next.increaseValue(value); | |||
| } | |||
| LOGGER.debug("Could not change value '{}' ot type {} by any field value changer", value, value.getClass()); | |||
There was a problem hiding this comment.
shall we add more info to this log? to create custom value changers in that case?
shall it be in WARN level?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal solution for #240.
The problem was the lombok @builder generates an all args constructor. Pojo tester invokes that constructor with generated values.
When the valueChanger tried to change inner class value, because it doesn't find a corresponding valueChanger it returned the same value.
A solution is to return null, which is by construction different from the initial generated value.