Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Bazel 7 #368

Closed
wants to merge 2 commits into from
Closed

Conversation

alexeagle
Copy link
Contributor

No description provided.

@alexeagle
Copy link
Contributor Author

Current build failure due to bazelbuild/bazel@a76763c

Fixed by https://github.com/bazelbuild/rules_apple/releases/tag/3.0.0-rc2

Replaced apple_common.multi_arch_split with new transition, this should not be a breaking change but is required for bazel 7.x support. Please file any issues you find!

@pcj
Copy link
Member

pcj commented Mar 11, 2024

Looks like com_github_grpc_grpc isn't happy yet.

@alexeagle
Copy link
Contributor Author

@pcj do you have more pointers about what's broken with it?

@pcj
Copy link
Member

pcj commented Mar 11, 2024

@alexeagle Just looking at the logs from https://github.com/stackb/rules_proto/actions. Maybe it just needed more recent rules_apple as you recently committed. CI has new error though.

@pcj
Copy link
Member

pcj commented Mar 11, 2024

Also was looking at grpc/grpc#35391. Hopefully will work. There should be tests here for virtual imports.

@alexeagle
Copy link
Contributor Author

grpc/grpc@45aecbe is the beginning of "Bazel 7 to the support bazel versions" so trying to upgrade to oldest release containing that.

@pcj
Copy link
Member

pcj commented Mar 13, 2024

Seems like the apple version isn't quite right?

Error: file '@build_bazel_apple_support//configs:platforms.bzl' does not contain symbol 'CPU_TO_DEFAULT_PLATFORM_NAME'

@alexeagle
Copy link
Contributor Author

Sorry, I hope to come back to this but I'm not sure when I'll get time. If the client we're working for is able to upgrade to Bazel 7 without changes here, then I'll have less reason to prioritize it.

@alexeagle
Copy link
Contributor Author

Our client finished their Bazel 7 upgrade, so this isn't critical for users. Just a housekeeping change for development in the repo.
I'm not planning to work on it more.

@alexeagle alexeagle closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants