Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove background color transitions from dark/light switch #53

Merged
merged 1 commit into from Oct 13, 2022
Merged

fix: remove background color transitions from dark/light switch #53

merged 1 commit into from Oct 13, 2022

Conversation

kevinzunigacuellar
Copy link
Contributor

@kevinzunigacuellar kevinzunigacuellar commented Oct 13, 2022

PR Description

This PR fixes the issue number: #52

Summary of my changes and explanation of my decisions

  • remove background-color transitions

Self-check

Please check all that apply:

  • My code follows the style guidelines of this project
  • I have reviewed my code or content update and edited it to the best of my abilities
  • I have commented my code, particularly in hard-to-understand areas; my comments are concise

Contributors list

Would you like your contribution to be celebrated? Please check all that apply:

(~idk 😅) I was testing out codeflow

  • I would like to be featured on the future contributors list in the README. If so, please tell us:

    • what name you'd like to be shown there?
    • we usually link github profile pic -- is that ok? If not, provide another url:
    • we usually link your github profile but if you have a portfolio page, provide a link:
  • I would like to get a shoutout in the next monthly updates post. If so, please provide your twitter handle (or we will link to your GitHub profile).

    • Twitter: @kevinzunigacuel

⚡️ ⚡️ ⚡️ Thank you for contributing to StackBlitz ⚡️ ⚡️ ⚡️

@stackblitz
Copy link

stackblitz bot commented Oct 13, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Oct 13, 2022

Deploy Preview for stackblitz-docs ready!

Name Link
🔨 Latest commit 6ff5f72
🔍 Latest deploy log https://app.netlify.com/sites/stackblitz-docs/deploys/63483c622cd56e0009af331f
😎 Deploy Preview https://deploy-preview-53--stackblitz-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kevinzunigacuellar kevinzunigacuellar changed the title fix: remove background color transitions fix: remove background color transitions from dark/light switch Oct 13, 2022
@fvsch
Copy link
Member

fvsch commented Oct 13, 2022

I'd prefer if we could address the issue upstream in Vitepress.

@fvsch
Copy link
Member

fvsch commented Oct 13, 2022

Tried it in the preview deploy, and it does feel like a small improvement.

Given that it's not a big fix, I think it would be okay to have this in our fixes.scss styles.

@sylwiavargas what do you think?

@sylwiavargas
Copy link
Contributor

Hi @kevinzunigacuellar! Thank you for the contribution - and for being the first external contributor to make a PR using Codeflow! 💙
@fvsch - I'd say we could do both! Merge this fix and address the issue upstream with VitePress.

@kevinzunigacuellar would you like to raise an issue with VitePress (we are using VitePress default theme)? We can do that as well but since this is your "find", wanted to ask you :)

@sylwiavargas sylwiavargas self-requested a review October 13, 2022 18:15
@kevinzunigacuellar
Copy link
Contributor Author

hello @sylwiavargas thank you for accepting my PR 🚀. I can raise an issue to VitePress and link the issue here to track its progress.

I wanted to try codeflow and it was very smooth (love it 🦄). I will start using it all the time btw. I don't know if the offer of joining the contributor list is still open but if it is I would love to be part of it. Once again thank you and @fvsch for taking the time to review my PR. Have a nice day

@kevinzunigacuellar
Copy link
Contributor Author

vuejs/vitepress#1479 got merged 🥳

@kevinzunigacuellar kevinzunigacuellar deleted the kevinzunigacuellar/dark-ligth-switch branch October 14, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants