Moving Away from SHA1 to SHA512 (Security) #527
Conversation
|
@stakater-user @faizanahmad055 Can you please review this? |
|
@shantanubansal Yikes! You better fix it before anyone else finds out! Build has Failed! |
shantanubansal
changed the title
|
@shantanubansal Yikes! You better fix it before anyone else finds out! Build has Failed! |
This reverts commit c9a25c9.
shantanubansal
changed the title
|
@shantanubansal Image is available for testing. |
|
@shantanubansal Image is available for testing. |
|
@karl-johan-grahn Can you please approve this PR? |
|
@waseem-h @ahmedwaleedmalik @stakater-user @faizanahmad055 @karl-johan-grahn Can anyone of you please approve or review the PR? |
|
/lgtm |
|
@shantanubansal please refrain from tagging individuals directly. I'm no longer working on this project. |
|
@shantanubansal Thank you for the PR, Can you please pull the upstream changes from the master and I can then review it? Also, at this point, I am unsure of the performance impact. We used SHA1 because it was efficient as the only purpose was to identify the objects. I am leaning towards making it configurable from a list of hashing algorithms. What do you think @MuneebAijaz ? |
|
@faizanahmad055 I feel we can make it configurable, if we can have a go-boring compatibility that will be awesome. But Can you please elaborate whats the performance impact? |
|
@shantanubansal Image is available for testing. |
|
@shantanubansal Image is available for testing. |
It can hit computationally harder to calculate and compare the hash specially when there is going to be too much load. I think making it an optional and choosing from the list of algorithms with default of SHA1 would be the way to go. |
|
@karl-johan-grahn Images are available for testing. |
|
@karl-johan-grahn Images are available for testing. |
|
@shantanubansal can we cater the feedback @faizanahmad055 has suggested above so this can be merged? |
|
Any chance this PR can be looked at by a dev team member? |
No description provided.