Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Angular 13 support (+rxjs 7) #632

Merged
merged 1 commit into from Jun 14, 2022
Merged

feat: Angular 13 support (+rxjs 7) #632

merged 1 commit into from Jun 14, 2022

Conversation

gloaec
Copy link
Contributor

@gloaec gloaec commented Jun 8, 2022

Hi,

First of all, i read some of your messages about the situation you are living right now, and I am really sorry that you have to go through any of this. I hope the situation gets better soon.

This is our modest contribution (with @MrP) to the project, i guess a couple of people are stuck migrating to Angular 13 rn :)

Anyway, let us know how we can help and get this merged.
In the meantime, take care and be safe :*

Fixes : #601
Related MR : #580

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2022

Codecov Report

Merging #632 (d460ed1) into master (9f91ac4) will decrease coverage by 0.10%.
The diff coverage is 92.68%.

@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
- Coverage   93.95%   93.84%   -0.11%     
==========================================
  Files          32       32              
  Lines         711      715       +4     
  Branches      167      173       +6     
==========================================
+ Hits          668      671       +3     
- Misses         12       13       +1     
  Partials       31       31              
Impacted Files Coverage Δ
packages/casl-prisma/src/PrismaAbility.ts 100.00% <ø> (ø)
packages/casl-prisma/src/prisma/PrismaQuery.ts 100.00% <ø> (ø)
...ckages/casl-prisma/src/prisma/PrismaQueryParser.ts 93.84% <75.00%> (-1.07%) ⬇️
packages/casl-mongoose/src/accessible_records.ts 80.00% <88.88%> (-5.19%) ⬇️
packages/casl-ability/src/utils.ts 95.23% <91.30%> (-0.82%) ⬇️
packages/casl-ability/src/RuleIndex.ts 94.87% <95.23%> (+0.42%) ⬆️
packages/casl-ability/src/extra.ts 91.89% <100.00%> (ø)
packages/casl-ability/src/structures/LinkedItem.ts 100.00% <100.00%> (ø)
packages/casl-angular/src/AbilityModule.ts 100.00% <100.00%> (ø)
packages/casl-angular/src/pipes.ts 100.00% <100.00%> (+4.16%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d788eaf...d460ed1. Read the comment docs.

@stalniy
Copy link
Owner

stalniy commented Jun 14, 2022

hey, thank you for the contribution! This is a breaking change because peer dependencies are changed to 13.0.0. Can be a patch release instead?

@gloaec
Copy link
Contributor Author

gloaec commented Jun 14, 2022

Sure, or ppl will just change dependency to the new version I guess.

I don't know the release procedure though, should I do it or let you take things from here ?

Cheers

@gloaec
Copy link
Contributor Author

gloaec commented Jun 14, 2022

Or maybe I missunderstood : you want to keep compatibility with Angular 12 ?

@stalniy
Copy link
Owner

stalniy commented Jun 14, 2022

ok let's merge it as it's. anyway, supporting multiple ng versions is a headache and starting from 13 there is no ViewEngine anymore what is good :)

@stalniy stalniy merged commit 6b86fd9 into stalniy:master Jun 14, 2022
@gloaec
Copy link
Contributor Author

gloaec commented Jun 14, 2022

Alright :)

Thanks mate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 13 and rxjs update
3 participants