New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for RxJS 7.0 and Angular 13 #580
Conversation
"@casl/ability": "^3.0.0 || ^4.0.0 || ^5.1.0", | ||
"rxjs": "^6.5.3", | ||
"rxjs": "^6.5.3 || ^7.0.0", | ||
"tslib": "^2.0.0" | ||
}, | ||
"devDependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in devDependencies you need to update rxjs
, so then when test pass I will know it uses the correct version of rxjs
@@ -46,9 +46,9 @@ | |||
"author": "Sergii Stotskyi <sergiy.stotskiy@gmail.com>", | |||
"license": "MIT", | |||
"peerDependencies": { | |||
"@angular/core": "^12.0.0", | |||
"@angular/core": "^12.0.0 || ^13.0.0-0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it works properly with Angular v13. You need to update dev deps angular version to ensure that it's true
Codecov Report
@@ Coverage Diff @@
## master #580 +/- ##
==========================================
- Coverage 93.95% 93.74% -0.22%
==========================================
Files 32 32
Lines 711 719 +8
Branches 167 174 +7
==========================================
+ Hits 668 674 +6
- Misses 12 13 +1
- Partials 31 32 +1
Continue to review full report at Codecov.
|
@stalniy can you have a look at the failing test? I'm a bit stuck on it. |
I’ll take a look tomorrow |
bump |
Tests are not passing. Additionally I’d like somebody to check that this casl example works properly with rxjs 7, angular 13 and updated version of casl I don’t have laptop right now and will not have one for the next few weeks. We have a war in Ukraine and sadly… my family was shelled. currently casl is the smallest of my problems. So, go ahead and do extra work |
@stalniy I hope you are doing okay! @jochenjonc if you need I can try taking a look at this to get tests passing |
close in favor of #632 |
Upgrade of the peerDependecies to be able to support Angular 13 and RxJS 7.
I looked at the peerDependecies used by Angular in their repo, https://github.com/angular/components/blob/12.2.x/packages.bzl.
I hope this change is enough, I'm not familiar with pnmn and did not succeed in building the project on my machine.