Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update angular to v15 #704

Merged
merged 1 commit into from Dec 17, 2022
Merged

chore(deps): update angular to v15 #704

merged 1 commit into from Dec 17, 2022

Conversation

mbarzda
Copy link
Contributor

@mbarzda mbarzda commented Nov 21, 2022

Update Angular to 15.0.0.

Note: jest-preset-angular still has peerDependencies Angular >=12.2.16 <15.0.0

@Sayene
Copy link

Sayene commented Dec 5, 2022

jest-preset-angular has been updated to 12.2.3, now supporting angular 15

@xbisa
Copy link

xbisa commented Dec 12, 2022

@serhiistotskyi The errors in the build are related to the Vue package. It makes sense because you build everything, but it's not related to the changes the PR author made.

@robinyao2
Copy link

hi @serhiistotskyi,
Can we fix this issue asap? We cannot upgrade angular to v15 if we use CASL in the project.
Thank a lot.

@xbisa
Copy link

xbisa commented Dec 16, 2022

If you download the log archive, you can see the problem is the following

2022-11-21T19:26:51.9534534Z packages/casl-vue prebuild: ../../node_modules/.pnpm/@vue/runtime-core@3.0.11/node_modules/@vue/runtime-core/dist/runtime-core.d.ts(1334,33): error TS2344: Type 'HostElement' does not satisfy the constraint 'RendererElement'.

Vue ships with erroneous type definitions. A workaround is setting "skipLibCheck": true in tsconfig.json:

{
  "extends": "../../tsconfig",
  "include": [
    "src/*",
    "spec/*"
  ],
  "compilerOptions": {
    "outDir": "dist/types",
    "types": ["vue"],
    "skipLibCheck": true
  }
}

@serhiistotskyi can you accept this solution?

@stalniy
Copy link
Owner

stalniy commented Dec 16, 2022

The issue in vuejs has been fixed in summer -> vuejs/core#6554

is it possible to update angular without updating typescript to 4.8.x?

If not, the the proper fix in this case is to fix vuejs first. I’ll try to look into this tomorrow.

@Sayene
Copy link

Sayene commented Dec 16, 2022

Thanks @stalniy,
Angular v15 requires TypeScript version 4.8 or later see

Removes @abraham/reflection as uneeded dev dep
@stalniy stalniy merged commit 4f4b713 into stalniy:master Dec 17, 2022
@stalniy
Copy link
Owner

stalniy commented Dec 17, 2022

released in @casl/angular@8.2.0

@xbisa
Copy link

xbisa commented Dec 17, 2022

Thanks @stalniy. Very appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants