Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patched the loader for files with .js extension #877

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Patched the loader for files with .js extension #877

wants to merge 4 commits into from

Conversation

compile-this
Copy link

This prevents the new default behaviour in Node 12+ of erroring when importing dependencies with commonjs syntax files from an ESM module.

See issue #868

@compile-this
Patched the loader for files with .js extension, preventing the default
dde90ad 
behaviour of erroring when importing dependencies with commonjs syntax files
@compile-this
Update @babel/preset-env package
a96bf1f
@compile-this
update @babel-prefix version
6e76351 
to remove warning about out of date dependencies
@compile-this
skip --check tests in Node 12+
2640c85 
node code paths for this functionality have changed and no longer
involve the patched loaders
@seanCodes seanCodes mentioned this pull request Jul 14, 2020
Open
@niksy
Copy link

niksy commented Jan 14, 2021

What is the status of this PR? What can we do to get this merged?

niksy added a commit to niksy/node-sass-json-functions that referenced this pull request Jan 14, 2021
@niksy
Use lower lodash version because of ESM bug
b209826 
Ref. https://github.com/lodash/lodash/issues/5033
Ref. standard-things/esm#868
Ref. standard-things/esm#877
michaelfig added a commit to agoric-labs/esm that referenced this pull request May 16, 2021
@michaelfig
fix: implement standard-things#877
8db4b72
This was referenced May 16, 2021
Merged
Closed
Merged
@mk-pmb
Copy link
Contributor

mk-pmb commented May 31, 2021 •
edited

@niksy Currently, the CI tests fail, so someone would need to fix those.
I also installed it locally and had the same error as in #898.

Markiz9999 pushed a commit to irls/esm that referenced this pull request Sep 17, 2021
fix: implement standard-things#877
18b1801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@compile-this @niksy @mk-pmb