-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ESLint 5 deprecation warning #49
Conversation
fixes #48 (right?) |
@standard ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
and why can I approve this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woop woop, works just great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -1,8 +1,7 @@ | |||
{ | |||
"parserOptions": { | |||
"ecmaVersion": 8, | |||
"ecmaVersion": 9, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, we are also having this warning and our ecmaVersion
is 7, while you upgrade from 8 to 9.
Is this what we also want upgrade to v9?>
Fix ESLint 5 deprecation warning of experimentalObjectRestSpread. Fixed #48