Eslint plugin react hooks

[vndre]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[x ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)

1. Updated base config to use eslint-plugin-react-hooks.
2. Updated test

I saw the other PR was quite a mess for such small changes so I created a new one.

Which issue (if any) does this pull request address?

#57

Is there anything you'd like reviewers to focus on?

[welcome]

🙌 Thanks for opening this pull request! You're awesome.

[ivanbanov]

is it expected to see this PR merged any time soon?

[LinusU]

Suggested change

	node_modules
	package-lock.json
	yarn.lock
	node_modules

Instead of adding lock files to the gitignore I think it's better to add an .npmrc file with package-lock=false in it. Otherwise people will be using a lock-file locally, it just won't be synchronised...

[vndre]

I agree with you, seems the owner of this PR doesn't know about programming.

[vndre]

I think a better solution would be to agree to use just one package manager to develop this and add it to a contributions or requirements section of the readme.

P.D: this PR just turned 1 year old 🥳

[barroudjo]

What's preventing this PR from being merged ?

[LinusU]

What's preventing this PR from being merged ?

[barroudjo]

So I guess I should start a new PR, based on these changes and your remarks, but without the conflicts ;-)
I'll get on it, it's high time standard-react uses these rules !
PS: non maintainers / author of the PR can't see what the conflicts are, so it's good you joined that screenshot

[LinusU]

PS: non maintainers / author of the PR can't see what the conflicts are, so it's good you joined that screenshot

Did not know that, thanks for telling me!

If you're creating a new PR, I have added the .gitignore changes in #74, so no need to add that 👍

[barroudjo]

Here is the new PR to solve this issue, but without the conflicts ;-)
#75

[LinusU]

added in #75