test: usage of ESLint class #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theoludwig
force-pushed
the
test/usage-of-eslint-class
branch
from
a5f3066
to
0e12f9b
Compare
voxpelli
approved these changes
Sep 14, 2021
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
ESLintclass instead of the deprecatedCLIEngineclass.eslintrc.jsonto.eslintrc.jsonto be consistent with the others config files, alsoconfigFileis an invalid option for theESLintclass.Why using more configurations and CLI options, if we don't need them? Keep It, Simple Stupid. 馃槃
In the next major version of ESLint (v8), the
CLIEngineclass will be removed (see: https://github.com/eslint/eslint/blob/v8-migration-guide/docs/user-guide/migrating-to-8.0.0.md#remove-cliengine).This allows a "smoother" update of
eslint@8when it will be released. 馃憤Related: standard/standard-engine#234