Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ESLint 7.x #1518

Closed
6 tasks done
LinusU opened this issue May 11, 2020 · 7 comments
Closed
6 tasks done

Upgrade to ESLint 7.x #1518

LinusU opened this issue May 11, 2020 · 7 comments

Comments

@LinusU
Copy link
Member

LinusU commented May 11, 2020

We should also consider adding these new rules:

ref: https://eslint.org/blog/2020/05/eslint-v7.0.0-released

@Raynos
Copy link

Raynos commented May 17, 2020

All of these changes are reasonable. I'm excited about bumping to eslint @ 7.

@evanplaice
Copy link

Is there anything specifically blocking progress on this?

The reason I ask is. ESLint isn't equipped to backport security fixes to the prior SemVer Major and another vulnerability was found in Lodash (ie which ESLint uses).

It'll probably be an easy fix (ie bump sub deps) but sometimes it isn't (ie the offending sub dep isn't maintained).

Keeping StandardJS in lockstep with ESLint's SemVer major can help this by ensuring any recent patches to ESLint are immediately available.


Sorry in advance if this is annoying. I woleheartedly agree.

@mcdado
Copy link

mcdado commented Jul 9, 2020

When upgrading to 7.x, if you jump to 7.4 directly, could you consider adding this option? #1474

I contributed the feature myself to eslint so that it could be included in standard, if you agree 😉

@NemoStein
Copy link

In #1539 (referenced by @shadowspawn) I asked for ESLint 7.5 because of the Optional Chaining operator (and the Nullish Coalescing operator by extension).
And I think that the rules no-promise-executor-return and no-unreachable-loop (ESLint 7.3) are good rules to be added.
Also, no-loss-of-precision (ESLint 7.1.0) and sort-imports (ESLint 7.5), although probable breakers, should be parte of the ruleset.

@NemoStein
Copy link

Hey, guys, please... This issue must move on...
Using latest spec syntax is essencial to push JS applications to next level and Standard is a huge part of the community.
Please, don't let this update die. =D

@feross
Copy link
Member

feross commented Oct 21, 2020

I'm working on this today.

@feross
Copy link
Member

feross commented Oct 22, 2020

This will be released in standard v15.

@feross feross closed this as completed Oct 22, 2020
@feross feross added this to the standard 15 milestone Oct 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

6 participants