Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ESLint 7 #1519

Merged
merged 1 commit into from Oct 21, 2020
Merged

Upgrade to ESLint 7 #1519

merged 1 commit into from Oct 21, 2020

Conversation

@Raynos
Copy link

Raynos commented May 17, 2020

I reviewed all related PRs.

3 have merged and two have been approved.

@ungoldman ungoldman linked an issue May 27, 2020 that may be closed by this pull request
@sheerun
Copy link

sheerun commented Jun 4, 2020

oh man, can't wait :)

@Raynos
Copy link

Raynos commented Oct 16, 2020

I’m not comfortable merging these PRs as is.

Would it be ok to create a temporary git repo standard7 and eslint-config-standard7 ?

I can merge all these PRs in there and then publish new npm packages standard7 / eslint-config-standard7 .

The community can play with these packages and once all the bugs are worked out everything can be merged into standard version 15

Cc @LinusU @feross @voxpelli

@voxpelli
Copy link
Member

I would suggest we merge them all to a 15.x branch and publish a 15.x prerelease from that branch instead

@feross
Copy link
Member

feross commented Oct 21, 2020

I'm working on this today.

Copy link
Member

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feross feross marked this pull request as ready for review October 21, 2020 21:01
@feross feross merged commit 523f004 into master Oct 21, 2020
@feross feross deleted the eslint7 branch October 21, 2020 21:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

support async iterables (for await...of)
5 participants