test: fix test to ensure --fix attempts #1958
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to note, it's possible I misunderstood the intent of these tests. They have been running long enough that it feels like this type of logic should have been caught earlier, especially given the level of talent contributing to this repo. @voxpelli or @LinusU perhaps either of you would be willing to chime in on this matter. No pressure. Just trying to knock out some low hanging fruit while we wait on #1948. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the tests were/are failing for the reason that --fix attempts were not actually being tried. This is because argv.fix was not set before the runStandard function being called. This should fix that.