Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Standard 17 #42

Closed
wants to merge 1 commit into from

Conversation

tagliala
Copy link

Close #41

What is the purpose of this pull request? (put an "X" next to item)
Allows use of Standard Engine 15 and Standard 17

[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
Simple PR

Which issue (if any) does this pull request address?
#41

Is there anything you'd like reviewers to focus on?
Everything, I'm not a javascript developer

@welcome
Copy link

welcome bot commented Apr 22, 2022

🙌 Thanks for opening this pull request! You're awesome.

Copy link

@tomaswarynyca tomaswarynyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@jankapunkt
Copy link

@feross is there something preventing to merge and publish this one?

@tagliala
Copy link
Author

@jankapunkt yes, there is actually an issue with snazzy and an upstream dependency not supporting warning messages

Refs:

@xChickens
Copy link

Any update regarding being able to fix the block in Snazzy? I wanted to use the newest version of the eslint-config-standard-with-typescript since the latest versions of typescript aren't officially supported, but standardx cause version conflicts since the config uses Standard 17, while standardx is still stuck on 16.

@tagliala
Copy link
Author

tagliala commented Apr 3, 2023

As a non javascript developer, during my brief investigation, I was not able to understand where the parsing happen, so the problem may not be in Snazzy only. Ref: standard/snazzy#29 (comment)

@tagliala
Copy link
Author

Moving to eslint, thanks for all these years

@tagliala tagliala closed this Dec 25, 2023
tagliala added a commit to diowa/ruby3-rails7-bootstrap-heroku that referenced this pull request Dec 25, 2023
Mostly because of unmaintained libraries in the Standard family and
the upcoming migration to Vite

Ref:
- standard/standardx#42
- standard/eslint-config-standard#229
- standard/standard-loader#104
tagliala added a commit to diowa/ruby3-rails7-bootstrap-heroku that referenced this pull request Dec 25, 2023
Mostly because of unmaintained libraries in the Standard family and
the upcoming migration to Vite

Ref:
- standard/standardx#42
- standard/eslint-config-standard#229
- standard/standard-loader#104
tagliala added a commit to diowa/ruby3-rails7-bootstrap-heroku that referenced this pull request Dec 25, 2023
Mostly because of unmaintained libraries in the Standard family and
the upcoming migration to Vite

Ref:
- standard/standardx#42
- standard/eslint-config-standard#229
- standard/standard-loader#104
tagliala added a commit to diowa/ruby3-rails7-bootstrap-heroku that referenced this pull request Dec 25, 2023
Mostly because of unmaintained libraries in the Standard family and
the upcoming migration to Vite

Ref:
- standard/standardx#42
- standard/eslint-config-standard#229
- standard/standard-loader#104
tagliala added a commit to diowa/ruby3-rails7-bootstrap-heroku that referenced this pull request Dec 25, 2023
Mostly because of unmaintained libraries in the Standard family and
the upcoming migration to Vite

Ref:
- standard/standardx#42
- standard/eslint-config-standard#229
- standard/standard-loader#104
tagliala added a commit to diowa/icare that referenced this pull request Dec 25, 2023
Mostly because of unmaintained libraries in the Standard family and
the upcoming migration to Vite

Ref:
- standard/standardx#42
- standard/eslint-config-standard#229
- standard/standard-loader#104
tagliala added a commit to diowa/ruby3-rails7-bootstrap-heroku that referenced this pull request Dec 25, 2023
Mostly because of unmaintained libraries in the Standard family and
the upcoming migration to Vite

Ref:
- standard/standardx#42
- standard/eslint-config-standard#229
- standard/standard-loader#104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Allow Standard 17
4 participants