Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add first automated tests #297

Merged
merged 2 commits into from Oct 8, 2021
Merged

Conversation

theoludwig
Copy link
Member

@theoludwig theoludwig commented Oct 7, 2021

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain: Add automated tests

What changes did you make? (Give an overview)

  • Add the first automated tests to ensure, that with all the engines (standard, semistandard, standardx and ts-standard), it works without problems, and it lints correctly.

    This will allow an easier upgrade when standard@17 will be released with standard-engine@15, as the next major version of standard-engine will contain lot of BREAKING CHANGES (see: Move APIs to Promise standard-engine#249, Usage of deprecated APIs of ESLint standard-engine#234).

  • Update Node.js v14 in GitHub Actions CI to always use the lts version.

  • Update .github/dependabot.yml to update GitHub Actions dependencies.

Which issue (if any) does this pull request address?

Closes #44

Is there anything you'd like reviewers to focus on?

@theoludwig theoludwig self-assigned this Oct 7, 2021
@theoludwig theoludwig force-pushed the test/add-first-automated-tests branch 2 times, most recently from be6f760 to 2423562 Compare October 7, 2021 09:21
@theoludwig theoludwig changed the title test: add-first-automated-tests test: add first automated tests Oct 7, 2021
@theoludwig theoludwig force-pushed the test/add-first-automated-tests branch from 968de46 to e219d7e Compare October 7, 2021 11:36
scripts/e2e.sh Show resolved Hide resolved
@theoludwig theoludwig requested a review from LinusU October 8, 2021 07:15
Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍

@theoludwig theoludwig merged commit 7d7377b into master Oct 8, 2021
@theoludwig theoludwig deleted the test/add-first-automated-tests branch October 8, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add tests
2 participants