feat(container): Add more ways of finding container name when in docker. #5958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two checks were added: * Docker usually sets the HOSTNAME variable to the container name. * Distrobox sets the CONTAINER_ID variable to the container name.
Zshoham
force-pushed
the
find_containerid_in_docker
branch
from
23fb36b
to
e8c5199
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using distrobox with docker and starship I noticed that the container name is not displayed, instead only "Docker".
This adds tow checks to find the actual container name:
How Has This Been Tested?
Checklist: