Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Typo (Boostrap -> Bootstrap) / German translation #158

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

zoh48gz04
Copy link

Farsi and Urdu might have to be changed?

@zoh48gz04 zoh48gz04 changed the title Fixed Typo (Boostrap -> Bootstrap) Fixed Typo (Boostrap -> Bootstrap) / German translation Oct 27, 2017
@fabiomartino
Copy link
Contributor

fabiomartino commented Oct 27, 2017

Hi
looks good!
Just missed the switch for german language into:

../src/app/shared/components/header/header.component.html around line 72
<a class="dropdown-item" href="javascript:void(0)" (click)="changeLang('de')">{{ 'German' | translate }}

and into ../src/app/app.component.ts line 10 and 13
translate.addLangs(['en', 'fr', 'ur', 'es', 'it', 'de', 'fa']);
translate.use(browserLang.match(/en|fr|ur|es|it|de|fa/) ? browserLang : 'en');

Also for each language the key/value (json) translation for 'German' is missed...

- Added translation for german language in all translations
- Added translation for german language in all translations
@zoh48gz04
Copy link
Author

Had the changes on disk but not commited..
Sorry for the commit mess, my dev environment of this project's embedded in another one.
Tell me if you want a clean up.

@fabiomartino
Copy link
Contributor

I don't have write access to this git repo.
I only can tell that your changes looks good for that desired functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants