Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing form submission config change in upgrade guide #10063

Closed
wiljanslofstra opened this issue May 14, 2024 · 1 comment · Fixed by #10066
Closed

Missing form submission config change in upgrade guide #10063

wiljanslofstra opened this issue May 14, 2024 · 1 comment · Fixed by #10066
Labels
forms

Comments

@wiljanslofstra
Copy link

wiljanslofstra commented May 14, 2024 •
edited by duncanmcclean

Bug description

We upgraded a few sites to Statamic 5. Only in our case we moved the submission directory to another location. The configuration was in forms.php > submissions. But it seems to be changed in version 5:

22c831f

We changed it, but I couldn't find any reference to the change in the upgrade guide. Maybe useful for people upgrading to version 5 in the future.

How to reproduce

Upgrade Statamic site from version 4 to 5.

Logs

No response

Environment

Environment
Application Name: [redacted]
Laravel Version: 10.48.10
PHP Version: 8.2.8
Composer Version: 2.7.6
Environment: production
Debug Mode: OFF
URL: [redacted]
Maintenance Mode: OFF

Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED

Drivers
Broadcasting: log
Cache: redis
Database: mysql
Logs: stack / single
Mail: smtp
Queue: redis
Session: file

Sentry
Enabled: YES
Environment: production
Laravel SDK Version: 3.8.2
PHP SDK Version: 3.22.1
Release: NOT SET
Sample Rate Errors: 100%
Sample Rate Performance Monitoring: 10%
Sample Rate Profiling: NOT SET
Send Default PII: DISABLED

Statamic
Addons: 10
Sites: 4 (NL, BE, UK, DE)
Stache Watcher: Disabled
Static Caching: Disabled
Version: 5.0.2 PRO

Statamic Addons
orangetalent/statamic-graphql-alternates: dev-dev
orangetalent/statamic-graphql-breadcrumbs: dev-dev
orangetalent/statamic-graphql-lang: 0.0.2
orangetalent/statamic-graphql-search: 0.0.4
orangetalent/statamic-graphql-sitemap: dev-dev
ryanmitchell/statamic-translation-manager: 1.5.0
studio1902/statamic-peak-browser-appearance: 2.0
studio1902/statamic-peak-commands: 2.7.0
studio1902/statamic-peak-seo: 2.6.2
studio1902/statamic-peak-tools: 3.4.3

Installation

Other (please explain)

Additional details

Upgrade from Statamic 4 to 5 (and also from 3 to 5)
@duncanmcclean
Copy link
Member

Whoops, that's a bug. The stache.stores.form-submissions.directory config should point to the config you already have customised. We'll get it sorted.

@duncanmcclean duncanmcclean mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
forms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[5.x] Remove submissions key from forms config statamic/cms
2 participants
@wiljanslofstra @duncanmcclean