Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Remove submissions key from forms config #10066

Merged
merged 3 commits into from
May 14, 2024

Conversation

duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented May 14, 2024

This pull request changes the directory for the Form Submissions Stache store, so it points to the existing forms.submissions config option we have for the form submissions storage path.

This means that those who want to customize the form submissions path won't need to do it in two config files, just forms.php like they did in v4.

Closes #10063.

@duncanmcclean
Copy link
Member Author

Alternatively, we could do the opposite of this... remove the forms.submissions setting in favour of the Stache setting, then document it as a breaking change?

@jasonvarga
Copy link
Member

jasonvarga commented May 14, 2024

Let's do your alternative. We removed the usage of config('statamic.forms.submissions') in #6455 but didn't remove it from the config file. We should have just documented it as a breaking change. 👍 Can you also remove it from the forms.php config?

@duncanmcclean duncanmcclean changed the title [5.x] Use existing config for Form Submissions Stache path [5.x] Remove submissions config option from forms config May 14, 2024
@duncanmcclean
Copy link
Member Author

duncanmcclean commented May 14, 2024

Let's do your alternative. We removed the usage of config('statamic.forms.submissions') in #6455 but didn't remove it from the config file. We should have just documented it as a breaking change. 👍 Can you also remove it from the forms.php config?

Done! I've also submitted a PR to statamic/statamic to mirror this PR: statamic/statamic#71.

@duncanmcclean duncanmcclean changed the title [5.x] Remove submissions config option from forms config [5.x] Remove submissions key from forms config May 14, 2024
@jasonvarga jasonvarga merged commit 0268a5e into 5.x May 14, 2024
33 checks passed
@jasonvarga jasonvarga deleted the fix/form-submissions-stache-path branch May 14, 2024 14:52
duncanmcclean added a commit to statamic/docs that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing form submission config change in upgrade guide
2 participants